Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh browser for all transitively referencing projects #45096

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

tmat
Copy link
Member

@tmat tmat commented Nov 24, 2024

We only looked for browser refresh server associated with the project containing changes, but we also need to look for browser refresh server on all transitively referencing projects.

Fixes regression #45011
Port of #45095 w/o test (necessary test infra isn't in 1xx branch)

Customer Impact

Changes made to Razor component did not trigger the web page to be refreshed.

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

One-liner to fix read buffer bounds.

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch untriaged Request triage from a team member labels Nov 24, 2024
Copy link
Contributor

Thanks for your PR, @tmat.
To learn about the PR process and branching schedule of this repo, please take a look at the SDK PR Guide.

@tmat tmat force-pushed the FixScoppedCssDeps1xx branch from b635a3a to 6224ed9 Compare November 24, 2024 19:40
@tmat tmat force-pushed the FixScoppedCssDeps1xx branch from 6224ed9 to 2b72907 Compare November 24, 2024 19:43
@tmat tmat marked this pull request as ready for review November 24, 2024 19:45
@phil-allen-msft phil-allen-msft self-requested a review November 27, 2024 04:04
@leecow leecow added this to the 9.0.2 milestone Dec 12, 2024
@tmat tmat merged commit 9809204 into dotnet:release/9.0.1xx Dec 12, 2024
31 checks passed
@tmat tmat deleted the FixScoppedCssDeps1xx branch December 12, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch Area-Watch Servicing-approved untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants